From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: tweak tx path debugging
Date: Wed, 28 Nov 2007 09:56:03 -0500 [thread overview]
Message-ID: <1196261763.28264.3.camel@localhost.localdomain> (raw)
In-Reply-To: <200711281408.13037.hs4233@mail.mn-solutions.de>
On Wed, 2007-11-28 at 14:08 +0100, Holger Schurig wrote:
> Make two functions in the TX packet path emit
> their debug messages with LBS_DEB_TX, not LBS_DEB_MAIN.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> Before this, any TXed packed did emit some messages with
> "lbsdebug +enter +main", which was a bit annoying.
>
> Index: wireless-2.6/drivers/net/wireless/libertas/main.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/main.c 2007-11-28 14:35:45.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/main.c 2007-11-28 14:37:13.000000000 +0100
> @@ -514,7 +514,7 @@ static int lbs_hard_start_xmit(struct sk
> int ret = 0;
> struct lbs_private *priv = dev->priv;
>
> - lbs_deb_enter(LBS_DEB_NET);
> + lbs_deb_enter(LBS_DEB_TX);
>
> if (priv->dnld_sent || priv->adapter->TxLockFlag) {
> priv->stats.tx_dropped++;
> @@ -528,7 +528,7 @@ static int lbs_hard_start_xmit(struct sk
> if (lbs_process_tx(priv, skb) == 0)
> dev->trans_start = jiffies;
> done:
> - lbs_deb_leave_args(LBS_DEB_NET, "ret %d", ret);
> + lbs_deb_leave_args(LBS_DEB_TX, "ret %d", ret);
> return ret;
> }
>
> @@ -564,7 +564,7 @@ static int lbs_pre_start_xmit(struct sk_
> struct lbs_private *priv = dev->priv;
> int ret;
>
> - lbs_deb_enter(LBS_DEB_NET);
> + lbs_deb_enter(LBS_DEB_TX);
>
> if (priv->adapter->monitormode != LBS_MONITOR_OFF) {
> netif_stop_queue(dev);
> @@ -574,7 +574,7 @@ static int lbs_pre_start_xmit(struct sk_
> UNSET_MESH_FRAME(skb);
>
> ret = lbs_hard_start_xmit(skb, dev);
> - lbs_deb_leave_args(LBS_DEB_NET, "ret %d", ret);
> + lbs_deb_leave_args(LBS_DEB_TX, "ret %d", ret);
> return ret;
> }
>
prev parent reply other threads:[~2007-11-28 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 13:08 [PATCH] libertas: tweak tx path debugging Holger Schurig
2007-11-28 14:56 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196261763.28264.3.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox