From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: set interface MAC address after driver's start() is called
Date: Thu, 29 Nov 2007 17:06:48 +0800 [thread overview]
Message-ID: <1196327209.7614.113.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1196326174.6058.173.camel@johannes.berg>
On Thu, 2007-11-29 at 09:49 +0100, Johannes Berg wrote:
> This cannot possibly work We do a lot of MAC address sanity checking
> at _open() time *before* the place where you inserted the MAC address
> copy.
I tested the patch. It works.
> Deferring MAC address setting to open() time is also *very* bad for
> the user experience because they no longer have the guarantee the the
> MAC address they see is the one that will be used when the interface
> is brought up.
Users see 00:00:00:00:00:00 address before up.
Anyway, Tomas pointed my assert for "iwlwifi cannot get MAC address
without firmware being loaded first" is not true. So I don't need to
change mac80211 to adapt this any more (not sure if other driver
requires). An updated patch for iwlwifi will be sent shortly.
Thanks,
-yi
next prev parent reply other threads:[~2007-11-29 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 1:34 [PATCH 1/2] mac80211: set interface MAC address after driver's start() is called Zhu Yi
2007-11-29 1:34 ` [PATCH 2/2] iwlwifi: delay firmware loading from pci_probe to network interface open Zhu Yi
2007-11-29 8:49 ` [PATCH 1/2] mac80211: set interface MAC address after driver's start() is called Johannes Berg
2007-11-29 9:06 ` Zhu Yi [this message]
2007-11-29 9:21 ` Johannes Berg
2007-11-29 9:22 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196327209.7614.113.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).