From: Johannes Berg <johannes@sipsolutions.net>
To: Ron Rindjunsky <rindjon@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>,
Tomas Winkler <tomasw@gmail.com>, Jouni Malinen <j@w1.fi>
Subject: Re: [RFC] mac80211: clean up frame receive handling
Date: Sun, 16 Dec 2007 14:49:34 +0100 [thread overview]
Message-ID: <1197812974.16079.64.camel@johannes.berg> (raw)
In-Reply-To: <c85cb4470712160128t7ef525f3md56d05f5990eb81@mail.gmail.com> (sfid-20071216_092840_096498_4E5966AB)
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
> > + if (local->bridge_packets && (sdata->type == IEEE80211_IF_TYPE_AP ||
> > + sdata->type == IEEE80211_IF_TYPE_VLAN) &&
>
> i may miss something, but wouldn't you prefer to use eth_type_trans
> here and just add compare_ether_addr check after it?
Yes, I think I would, but I also think it's wrong to call
eth_type_trans. We always remove the rfc2042 header and replace it with
a regular ethernet header; but in the case there was no rfc2042 header
we just stick in the length. But the length of a wireless packet can be
bigger than the 1536 below which eth_type_trans assumes it's a length,
so when we stick in a length>1536 it'll assume it's not a length but
rather an ethertype, which will be wrong.
The thing is, I couldn't so far even find the case where we receive a
frame *without* rfc2042 header.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-12-16 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 18:24 [RFC] mac80211: clean up frame receive handling Johannes Berg
2007-12-12 18:39 ` drago01
2007-12-13 11:35 ` Johannes Berg
2007-12-13 20:49 ` John W. Linville
2007-12-14 12:14 ` Johannes Berg
2007-12-18 4:22 ` Jouni Malinen
2007-12-18 12:42 ` Johannes Berg
2007-12-14 5:08 ` Jouni Malinen
2007-12-14 12:13 ` Johannes Berg
2007-12-18 4:18 ` Jouni Malinen
2007-12-18 12:47 ` Johannes Berg
2007-12-16 9:28 ` Ron Rindjunsky
2007-12-16 13:49 ` Johannes Berg [this message]
2007-12-18 14:16 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197812974.16079.64.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rindjon@googlemail.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).