RE: [PATCH 6/8] mac80211: A-MPDU Rx adding BAR handling capability

Rindjunsky, Ron
2007-12-19T13:26:08Z

>>> + switch (type) {
>>> + case IEEE80211_IF_TYPE_STA:
>>> + return hdr->addr2;
>>> + case IEEE80211_IF_TYPE_AP:
>>> + return hdr->addr1;
>>> + }
>>
>> Doesn't that result in a compiler warning? And what does happen if we
>> receive a BACK_REQ when we're an IBSS/MESH?

> I guess we should just return NULL in all other cases here. But please
> enumerate the cases explicitly so that people who add new interface
> types get warnings, i.e. don't use a default: statement in a switch
> (interface type)

you sure you want these ugly warnings? I do prefer to put default here.

> johannes
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.