Re: [PATCH 1/8] mac80211: A-MPDU Rx add low level driver API

Ron Rindjunsky
2007-12-18T13:41:06Z

> > +enum ieee80211_ampdu_mlme_flags {
> > + IEEE80211_AMPDU_RX_START = 1<<0,
> > + IEEE80211_AMPDU_RX_STOP = 1<<1,
> > +};
>
> Can both really happen at the same time? Or why are they flags rather
> than just an action code?
>
i agree, it is confusing. i will change this enum to what you suggested.

thanks for typos and comments catches, i will fix them.

>
> @ssn will highlight the variable name afaik. I need to get my docbook
> stuff up to be mergeable.
>

didn't get this one. i didn't do @ssn as no other comment in
ieee80211_ops does it, it was just my extra info for drivers writers.