RE: [PATCH 5/8] mac80211: A-MPDU Rx handling aggregation reordering

Winkler, Tomas
2007-12-19T16:29:55Z

>-----Original Message-----
>From: Johannes Berg [mailto:johannes@sipsolutions.net]
>Sent: Wednesday, December 19, 2007 5:47 PM
>To: Rindjunsky, Ron
>Cc: linville@tuxdriver.com; linux-wireless@vger.kernel.org;
>flamingice@sourmilk.net; Winkler, Tomas; Zhu, Yi
>Subject: RE: [PATCH 5/8] mac80211: A-MPDU Rx handling aggregation
>reordering
>
>
>> > I'm just not sure why you'd want to. As far as I can the frames
>> already
>> > passed __ieee80211_rx(), no? Maybe only as part of the aggregation?
>>
>> No, not passed it yet, they are still queued for reordering, but as
>> aggregation is being tear down I am expected to drop the frames
>> that are still not in order.
>
>But haven't they passed through __ieee80211_rx() as the aggregate
frame?

AMsDU aggregation is different from AMpDU aggregation. For AMPDU the
disaggregating is happening let say in PHY level. First one is many
packets in packed into one. Second one is packets in a row without ACK
between them. (You answer with Block Ack to them). They appear as
regular frames to mac80211 but they are not in order. Only ordered
sequence might be passed to the network stack. So we might drop the
frames are result of non order.
So what Ron was concerning about is whether we it's not waste of time to
pass packets through rx handler before we know the sequence is
completed.

Tomas
>johannes
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.