From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>
Subject: usefulness of 802.1X control?
Date: Wed, 19 Dec 2007 16:10:13 +0100 [thread overview]
Message-ID: <1198077014.4747.7.camel@johannes.berg> (raw)
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
Hi,
After a bit of rework in my patches, we only have two places left where
we use the 802.1X flag:
tx.c:
if (unlikely(sdata->ieee802_1x_pac &&
!(sta_flags & WLAN_STA_AUTHORIZED) &&
[...]
rx.c:
if (unlikely(rx->sdata->ieee802_1x_pac &&
(!rx->sta || !(rx->sta->flags & WLAN_STA_AUTHORIZED)))) {
[...]
That has me wondering if the control is actually useful. Instead of
checking this flag, we could simply require that hostapd sets the
WLAN_STA_AUTHORIZED flag on all stations if 802.1X is disabled. Do you
(or anyone else) see any problem with this?
We would of course have to set the WLAN_STA_AUTHORIZED flag on all
stations we add from within mac80211, i.e. the AP we're associating to,
other IBSS stations and the WDS peer, but that's trivial.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
reply other threads:[~2007-12-19 15:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198077014.4747.7.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox