From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwl4965: fix bogus hardware scan configuration caching
Date: Thu, 20 Dec 2007 13:56:08 +0800 [thread overview]
Message-ID: <1198130168.3065.50.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1198024224.4885.188.camel@johannes.berg>
On Wed, 2007-12-19 at 01:30 +0100, Johannes Berg wrote:
> When iwl4965 is scanning, it needs to cache any configuration
> requests.
> This was implemented but the implementation is buggy: it uses only
> the *first* configuration rather than the *last* that is requested
> during scanning. This patch fixes that and also removes a bogus
> comment related to the issue.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> This patch requires porting to iwl3965. For correctness, it
> needs to be applied to 2.6.24 although most likely nobody will
> ask to change channel twice during a single hardware scan. Duh!
>
> Warning: patch is not even compile tested yet because I currently have
> a broken tree. I don't see why it shouldn't work though.
NACK. We have a better fix that doesn't require to alloc buffer at all
in our tree. Will post it here later.
http://intellinuxwireless.org/repos/?p=iwlwifi.git;a=commitdiff;h=5f967087629a19b0c166101ddd227dee8ab2ec39
Thanks,
-yi
prev parent reply other threads:[~2007-12-20 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 0:30 [PATCH] iwl4965: fix bogus hardware scan configuration caching Johannes Berg
2007-12-20 5:56 ` Zhu Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198130168.3065.50.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).