linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Helmut Schaa <hschaa@suse.de>,
	linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Restore rx.fc before every invocation of ieee80211_invoke_rx_handlers
Date: Mon, 24 Dec 2007 11:34:54 +0800	[thread overview]
Message-ID: <1198467294.3065.180.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1198417706.4000.1.camel@johannes.berg>


On Sun, 2007-12-23 at 14:48 +0100, Johannes Berg wrote:
> Ah, that must be because of the stuff Zhu Yi did wrt. hw scanning.
> Could you take a look too please? The patch looks pretty much ok to me
> and I think it'd be required with say VLAN interfaces as well.

The patch looks fine to me. Hardware scanning is a trigger that makes
the condition more likely to happen, the patch itself fixes the more
general problem for multiple interfaces.

An off-topic question: should wmaster0 continue to execute more rx
handlers (i.e ieee80211_rx_h_remove_qos_control) even if it knows it
will drop them finially?

Thanks,
-yi


  parent reply	other threads:[~2007-12-24  3:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21 14:16 [PATCH] mac80211: Restore rx.fc before every invocation of ieee80211_invoke_rx_handlers Helmut Schaa
2007-12-23  9:24 ` Johannes Berg
2007-12-23 11:35   ` Helmut Schaa
2007-12-23 13:48     ` Johannes Berg
2007-12-23 15:52       ` Helmut Schaa
2007-12-24  3:34       ` Zhu Yi [this message]
2007-12-24 10:23         ` Johannes Berg
2007-12-24 11:49           ` Helmut Schaa
2007-12-25  3:31           ` Zhu Yi
2007-12-25 10:40             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1198467294.3065.180.camel@debian.sh.intel.com \
    --to=yi.zhu@intel.com \
    --cc=hschaa@suse.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).