From: Pavel Roskin <proski@gnu.org>
To: Marcin Juszkiewicz <openembedded@haerwu.biz>
Cc: linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>,
netdev@vger.kernel.org
Subject: Re: [PATCH] Add Linksys WCF11 to hostap driver
Date: Fri, 28 Dec 2007 23:14:49 -0500 [thread overview]
Message-ID: <1198901689.2221.3.camel@dv> (raw)
In-Reply-To: <200712281416.59079.openembedded@haerwu.biz>
Hello!
On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote:
> + PCMCIA_DEVICE_PROD_ID1234(
> + "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P",
> + "RevA",
> + 0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),
I would prefer that revisions are not used for card identification in
presence of the chip name. It's not like RevB would need another driver
as long as "ISL37300P" is still a part of the PCMCIA ID.
PCMCIA_DEVICE_PROD_ID123 should be enough.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2007-12-29 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 13:16 [PATCH] Add Linksys WCF11 to hostap driver Marcin Juszkiewicz
2007-12-29 4:14 ` Pavel Roskin [this message]
2007-12-30 15:00 ` Marcin Juszkiewicz
2007-12-30 16:39 ` Pavel Roskin
2008-01-08 21:29 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198901689.2221.3.camel@dv \
--to=proski@gnu.org \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openembedded@haerwu.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).