From: Krzysztof Kozlowski <krzk@kernel.org>
To: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>,
jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH ath-current 1/2] wifi: ath11k: add usecase firmware handling based on device compatible
Date: Fri, 12 Dec 2025 04:24:30 +0100 [thread overview]
Message-ID: <11c1304a-242f-4643-8128-a12c0dec49b2@kernel.org> (raw)
In-Reply-To: <20251204071100.970518-2-miaoqing.pan@oss.qualcomm.com>
On 04/12/2025 08:10, Miaoqing Pan wrote:
> @@ -1275,6 +1275,7 @@ bool ath11k_core_coldboot_cal_support(struct ath11k_base *ab);
>
> const struct firmware *ath11k_core_firmware_request(struct ath11k_base *ab,
> const char *filename);
> +const char *ath11k_core_get_usecase_firmware(struct ath11k_base *ab);
>
> static inline const char *ath11k_scan_state_str(enum ath11k_scan_state state)
> {
> @@ -1325,9 +1326,7 @@ static inline void ath11k_core_create_firmware_path(struct ath11k_base *ab,
> const char *filename,
> void *buf, size_t buf_len)
> {
> - const char *fw_name = NULL;
> -
> - of_property_read_string(ab->dev->of_node, "firmware-name", &fw_name);
> + const char *fw_name = ath11k_core_get_usecase_firmware(ab);
NAK, silent ABI break without explanation..
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-12 3:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 7:10 [PATCH ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible Miaoqing Pan
2025-12-04 7:10 ` [PATCH ath-current 1/2] " Miaoqing Pan
2025-12-11 1:38 ` Baochen Qiang
2025-12-12 3:24 ` Krzysztof Kozlowski [this message]
2025-12-04 7:11 ` [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property Miaoqing Pan
2025-12-09 19:56 ` Rob Herring (Arm)
2025-12-11 16:44 ` Jeff Johnson
2025-12-12 3:23 ` Krzysztof Kozlowski
2026-01-12 19:51 ` Jeff Johnson
2026-01-13 7:29 ` Krzysztof Kozlowski
2025-12-14 2:08 ` Miaoqing Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c1304a-242f-4643-8128-a12c0dec49b2@kernel.org \
--to=krzk@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing.pan@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox