From: Mattias Nissler <mattias.nissler@gmx.de>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org
Subject: Re: rc80211-pid: fix last_sample initialization
Date: Thu, 17 Jan 2008 00:49:33 +0100 [thread overview]
Message-ID: <1200527373.7499.5.camel@localhost> (raw)
In-Reply-To: <20080117003829.6d1c15cc@morte>
On Thu, 2008-01-17 at 00:38 +0100, Stefano Brivio wrote:
> Fix last_sample initialization. kzalloc'ing the per-STA data wasn't enough,
> as jiffies can assume negative values as well. This fixes a bug which
> prevented correct PID operation for a while after booting.
>
> Thanks to Michael Buesch for reporting this.
>
> Reported-and-tested-by: Michael Buesch <mb@bu3sch.de>
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Ack.
> ---
> Index: wireless-2.6/net/mac80211/rc80211_pid_algo.c
> ===================================================================
> --- wireless-2.6.orig/net/mac80211/rc80211_pid_algo.c
> +++ wireless-2.6/net/mac80211/rc80211_pid_algo.c
> @@ -496,6 +496,8 @@ static void *rate_control_pid_alloc_sta(
> if (spinfo == NULL)
> return NULL;
>
> + spinfo->last_sample = jiffies;
> +
> #ifdef CONFIG_MAC80211_DEBUGFS
> spin_lock_init(&spinfo->events.lock);
> init_waitqueue_head(&spinfo->events.waitqueue);
>
>
prev parent reply other threads:[~2008-01-16 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 23:38 rc80211-pid: fix last_sample initialization Stefano Brivio
2008-01-16 23:49 ` Mattias Nissler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200527373.7499.5.camel@localhost \
--to=mattias.nissler@gmx.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).