From: Johannes Berg <johannes@sipsolutions.net>
To: Ron Rindjunsky <ron.rindjunsky@intel.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: fix RCU locking in __ieee80211_rx_handle_packet
Date: Thu, 17 Jan 2008 16:36:17 +0100 [thread overview]
Message-ID: <1200584178.8007.48.camel@johannes.berg> (raw)
In-Reply-To: <c85cb4470801170732y4e0c1921n6e66836f7ebf495d@mail.gmail.com> (sfid-20080117_153252_992658_4E2FDA82)
[-- Attachment #1: Type: text/plain, Size: 655 bytes --]
On Thu, 2008-01-17 at 17:32 +0200, Ron Rindjunsky wrote:
> >
> > sparse actually detected this.... oh well
> >
>
> Arrrr... i did the re-structuring of Rx flow and forgot to sparse.
> I'll issue a patch to clean up the warnings.
No worries, the rest is just harmless missing "static" keywords. I
wonder though, should we get rid of that special case completely? Jiri
intended this as an 'optimisation' but since we rarely even hit the case
(I had to play with monitor interfaces *and* AP mode to hit it!!) it
probably hurts performance more by the extra branches and all that. And
it makes it harder to verify correctness...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2008-01-17 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 20:47 [PATCH] mac80211: fix RCU locking in __ieee80211_rx_handle_packet Johannes Berg
2008-01-17 15:32 ` Ron Rindjunsky
2008-01-17 15:36 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200584178.8007.48.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ron.rindjunsky@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox