Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	Zhu Yi <yi.zhu@intel.com>, Ian Schram <ischram@telenet.be>
Subject: Re: [PATCH 05/12] iwlwifi: delay firmware loading from pci_probe to network interface open
Date: Fri, 18 Jan 2008 13:35:20 +0100	[thread overview]
Message-ID: <1200659720.5716.24.camel@johannes.berg> (raw)
In-Reply-To: <1200361585-31801-6-git-send-email-reinette.chatre@intel.com> (sfid-20080115_022710_198103_7FE5555D)

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

> This patch moves the firmware loading (read firmware from disk and load
> it into the device SRAM) from pci_probe time to the first network
> interface open time. There are two reasons for doing this:

I have a bit of a problem with this patch...

You're supposed to register your hw modes before registering the hw,
that is no longer the case after this patch!

That's actually totally killing my cfg80211 rate API patch because that
complains if the bands in the registered hw/wiphy aren't assigned
properly.

Can you call *_init_geos() before registering the hw, i.e. before
initialising the firmware?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  parent reply	other threads:[~2008-01-18 12:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-15  1:46 [PATCH 00/12] iwlwifi driver updates Reinette Chatre
2008-01-15  1:46 ` [PATCH 01/12] iwl4965: Remove redundant code in iwl4965_tx_cmd Reinette Chatre
2008-01-15  1:46   ` [PATCH 02/12] iwlwifi: move iwl4965_get_dma_hi_address function to iwl-helpers.h Reinette Chatre
2008-01-15  1:46     ` [PATCH 03/12] iwlwifi: remove iwl4965_tx_cmd Reinette Chatre
2008-01-15  1:46       ` [PATCH 04/12] iwlwifi: document scan command Reinette Chatre
2008-01-15  1:46         ` [PATCH 05/12] iwlwifi: delay firmware loading from pci_probe to network interface open Reinette Chatre
2008-01-15  1:46           ` [PATCH 06/12] iwlwifi: fix problem when rf_killswitch change during suspend/resume Reinette Chatre
2008-01-15  1:46             ` [PATCH 07/12] iwlwifi: move uCode helper functions to iwl-helpers.h Reinette Chatre
2008-01-15  1:46               ` [PATCH 08/12] iwlwifi: 4965 unify rate scale variable names for station data Reinette Chatre
2008-01-15  1:46                 ` [PATCH 09/12] iwlwifi: 3954 renames iwl3945_rate_scale_priv to iwl3945_rs_sta Reinette Chatre
2008-01-15  1:46                   ` [PATCH 10/12] iwlwifi: Update iwlwifi version stamp to 1.2.23 Reinette Chatre
2008-01-15  1:46                     ` [PATCH 11/12] iwlwifi: remove reference to non-existent documentation Reinette Chatre
2008-01-15  1:46                       ` [PATCH 12/12] iwlwifi: style fixes to usage of << and >> operators Reinette Chatre
2008-01-18 12:35           ` Johannes Berg [this message]
2008-01-18 16:15             ` [PATCH 05/12] iwlwifi: delay firmware loading from pci_probeto network interface open Chatre, Reinette
2008-01-16  0:02         ` [PATCH 04/12] iwlwifi: document scan command Johannes Berg
2008-01-18 16:34           ` Cahill, Ben M
2008-01-18 20:39             ` Johannes Berg
2008-01-21 15:51               ` Cahill, Ben M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200659720.5716.24.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=ischram@telenet.be \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox