From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] libertas: fix memory alignment problems on the blackfin
Date: Fri, 25 Jan 2008 10:46:57 -0500 [thread overview]
Message-ID: <1201276017.1163.3.camel@localhost.localdomain> (raw)
In-Reply-To: <200801251415.00942.hs4233@mail.mn-solutions.de>
On Fri, 2008-01-25 at 14:15 +0100, Holger Schurig wrote:
> From: Ihar Hrachyshka <ihar.hrachyshka@promwad.com>
>
> Fixing unaligned memory access on the blackfin architecture (maybe on the
> ARM also).
>
> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@promwad.com>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
>
> Index: wireless-2.6/drivers/net/wireless/libertas/dev.h
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/dev.h 2008-01-25 10:03:29.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/dev.h 2008-01-25 14:03:00.000000000 +0100
> @@ -349,7 +349,7 @@ struct assoc_request {
> u8 channel;
> u8 band;
> u8 mode;
> - u8 bssid[ETH_ALEN];
> + u8 bssid[ETH_ALEN] __attribute__ ((aligned (2)));
>
> /** WEP keys */
> struct enc_key wep_keys[4];
> Index: wireless-2.6/drivers/net/wireless/libertas/assoc.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/assoc.c 2008-01-25 14:03:14.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/assoc.c 2008-01-25 14:03:33.000000000 +0100
> @@ -12,8 +12,10 @@
> #include "cmd.h"
>
>
> -static const u8 bssid_any[ETH_ALEN] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
> -static const u8 bssid_off[ETH_ALEN] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> +static const u8 bssid_any[ETH_ALEN] __attribute__ ((aligned (2))) =
> + { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF };
> +static const u8 bssid_off[ETH_ALEN] __attribute__ ((aligned (2))) =
> + { 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
>
>
> static int assoc_helper_essid(struct lbs_private *priv,
next prev parent reply other threads:[~2008-01-25 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 13:15 [PATCH] libertas: fix memory alignment problems on the blackfin Holger Schurig
2008-01-25 15:46 ` Dan Williams [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-09 0:18 Ihar Hrachyshka
2008-07-09 0:24 ` Harvey Harrison
2008-07-09 6:29 ` Ihar Hrachyshka
2008-07-10 11:29 ` Dan Williams
2008-07-09 13:21 ` Holger Schurig
2008-07-09 20:03 ` Ihar Hrachyshka
2008-07-09 20:07 ` Johannes Berg
2008-07-09 20:55 ` Ihar Hrachyshka
2008-07-09 21:02 ` Johannes Berg
2008-07-10 6:41 ` Holger Schurig
2008-07-09 21:07 ` Ihar Hrachyshka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201276017.1163.3.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).