From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: make association debug output nicer
Date: Mon, 28 Jan 2008 11:39:19 -0500 [thread overview]
Message-ID: <1201538359.14441.5.camel@localhost.localdomain> (raw)
In-Reply-To: <200801281725.53260.hs4233@mail.mn-solutions.de>
On Mon, 2008-01-28 at 17:25 +0100, Holger Schurig wrote:
> This also fixes a bug where should_deauth_infrastructure() always
> returned 0.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-2.6/drivers/net/wireless/libertas/assoc.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/assoc.c 2008-01-16 14:15:07.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/assoc.c 2008-01-16 15:19:16.000000000 +0100
> @@ -403,11 +403,10 @@ static int should_deauth_infrastructure(
> {
> int ret = 0;
>
> - lbs_deb_enter(LBS_DEB_ASSOC);
> -
> if (priv->connect_status != LBS_CONNECTED)
> return 0;
>
> + lbs_deb_enter(LBS_DEB_ASSOC);
> if (test_bit(ASSOC_FLAG_SSID, &assoc_req->flags)) {
> lbs_deb_assoc("Deauthenticating due to new SSID\n");
> ret = 1;
> @@ -446,7 +445,7 @@ static int should_deauth_infrastructure(
>
> out:
> lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
> - return 0;
> + return ret;
> }
>
>
> @@ -633,9 +642,7 @@ void lbs_association_worker(struct work_
> }
>
> if (success) {
> - lbs_deb_assoc("ASSOC: associated to '%s', %s\n",
> - escape_essid(priv->curbssparams.ssid,
> - priv->curbssparams.ssid_len),
> + lbs_deb_assoc("associated to %s\n",
> print_mac(mac, priv->curbssparams.bssid));
> lbs_prepare_and_send_command(priv,
> CMD_802_11_RSSI,
> Index: wireless-2.6/drivers/net/wireless/libertas/cmdresp.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/cmdresp.c 2008-01-16 14:37:41.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/cmdresp.c 2008-01-16 14:37:47.000000000 +0100
> @@ -74,7 +74,7 @@ void lbs_mac_event_disconnected(struct l
> lbs_deb_cmd("disconnected, so exit PS mode\n");
> lbs_ps_wakeup(priv, 0);
> }
> - lbs_deb_leave(LBS_DEB_CMD);
> + lbs_deb_leave(LBS_DEB_ASSOC);
> }
>
> /**
> Index: wireless-2.6/drivers/net/wireless/libertas/join.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/join.c 2008-01-16 15:19:49.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/join.c 2008-01-16 15:19:54.000000000 +0100
> @@ -769,9 +769,6 @@ int lbs_ret_80211_associate(struct lbs_p
> priv->curbssparams.ssid_len = bss->ssid_len;
> memcpy(priv->curbssparams.bssid, bss->bssid, ETH_ALEN);
>
> - lbs_deb_assoc("ASSOC_RESP: currentpacketfilter is 0x%x\n",
> - priv->currentpacketfilter);
> -
> priv->SNR[TYPE_RXPD][TYPE_AVG] = 0;
> priv->NF[TYPE_RXPD][TYPE_AVG] = 0;
>
prev parent reply other threads:[~2008-01-28 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 16:25 [PATCH] libertas: make association debug output nicer Holger Schurig
2008-01-28 16:39 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201538359.14441.5.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox