From: Johannes Berg <johannes@sipsolutions.net>
To: Luis Carlos Cobo <luisca@cozybit.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/13] o11s: (zd1211) support for mesh interface and beaconing
Date: Thu, 07 Feb 2008 01:19:50 +0100 [thread overview]
Message-ID: <1202343590.9965.50.camel@johannes.berg> (raw)
In-Reply-To: <47a78266.24528c0a.29f3.ffffdde9@mx.google.com> (sfid-20080204_212411_276523_290FB136)
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
> + if (hw->flags & IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE) {
> + zd_mac_config_beacon(hw, conf->beacon);
> + kfree_skb(conf->beacon);
> + zd_set_beacon_interval(&mac->chip, BCN_MODE_IBSS |
> + hw->conf.beacon_int);
As I already mentioned, hw flags are never set by mac80211. So the
driver should set this particular hw flag before hw registration and
then the conditional here can go away once you reworked the mac80211
code.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2008-02-07 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 18:52 [PATCH 03/13] o11s: (zd1211) support for mesh interface and beaconing Luis Carlos Cobo
2008-02-07 0:19 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202343590.9965.50.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luisca@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox