Re: [PATCH 04/13] o11s: various definitions and support functions for mesh interfaces

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]


>  	key.o \
>  	util.o \
> -	event.o
> +	event.o \
> +	mesh.o \
> +	mesh_pathtbl.o \
> +	mesh_plinktbl.o \
> +	mesh_plinkfsm.o \
> +	mesh_hwmp.o

Since this is a lot of code, any opinion on making it build-time
conditional? I can imagine that you don't want mesh when building an
embedded AP device.
 
> @@ -358,6 +366,10 @@ static int ieee80211_stop(struct net_device *dev)

> +	case IEEE80211_IF_TYPE_MESH_POINT:
> +		sdata->u.sta.state = IEEE80211_DISABLED;
> +		flush_mesh_interface(dev);
> +		/* fall through */
>  	case IEEE80211_IF_TYPE_STA:
>  	case IEEE80211_IF_TYPE_IBSS:
>  		sdata->u.sta.state = IEEE80211_DISABLED;

Setting the state twice seems a bit odd.

> +	} else if (sdata->vif.type == IEEE80211_IF_TYPE_MESH_POINT) {
> +		/* SSID is wildcard (all 0s) */
> +		ieee80211_set_mesh_beacon_template(dev, &conf);
> +		local->hw.flags |= IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE;
> +		local->hw.conf.beacon_int = 100;
> +		ieee80211_start_mesh(dev);

I already mentioned how that is wrong. Let me know if you need any more
info/help.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]