From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 07/13] o11s: support for mesh interfaces in mac80211 data path
Date: Fri, 08 Feb 2008 18:18:01 -0800 [thread overview]
Message-ID: <1202523481.7025.76.camel@localhost> (raw)
In-Reply-To: <1202345620.9965.80.camel@johannes.berg>
On Thu, 2008-02-07 at 01:53 +0100, Johannes Berg wrote:
> > + if (rx->sdata->vif.type == IEEE80211_IF_TYPE_MESH_POINT) {
> > + if ((rx->fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_DATA) {
> > + if (!((rx->fc & IEEE80211_FCTL_FROMDS) &&
> > + (rx->fc & IEEE80211_FCTL_TODS)))
>
> It'd be shorter to write
>
> if (rx->fc ^ (IEEE80211_FCTL_FROMDS | IEEE80211_FCTL_TODS))
>
> but I'm not sure that's easier to understand ;)
Would that work? For data frames rx->fc is 0xYY08 (with YY being the
flags, including fromDS/toDS), so they would always evaluate to true in
that if, regardless of the flags.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
next prev parent reply other threads:[~2008-02-09 2:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 19:17 [PATCH 07/13] o11s: support for mesh interfaces in mac80211 data path Luis Carlos Cobo
2008-02-07 0:53 ` Johannes Berg
2008-02-09 0:36 ` Luis Carlos Cobo
2008-02-11 9:30 ` Johannes Berg
2008-02-09 2:18 ` Luis Carlos Cobo [this message]
2008-02-11 7:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202523481.7025.76.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).