From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
Daniel Drake <dsd@gentoo.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] zd1211rw: Fix beacon filter flags thinko
Date: Mon, 11 Feb 2008 13:53:51 +0100 [thread overview]
Message-ID: <1202734431.11481.80.camel@johannes.berg> (raw)
In-Reply-To: <200802101603.56095.mb@bu3sch.de> (sfid-20080210_150436_186402_A253CCC1)
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
On Sun, 2008-02-10 at 16:03 +0100, Michael Buesch wrote:
> We must not clear the FIF_BCN_PRBRESP_PROMISC bit in the
> new_flags. The zd-driver does support sending beacons and
> probe responses to the host. What the flag does is say "Send me
> all beacons and probe responses". And we actually do that. We always
> do that, so we ignore the case when the bit is disabled. But that is
> fine. But we must not clear the flag, as that tells mac80211 that
> we do not support passing beacons and probe responses to the stack.
> And that's not true.
Good explanation. Maybe it's needed with the filter flags defines/the
config_filter callback description?
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>
> Should probably go -stable, too.
Unnecessary, I don't think we currently ever test the flag in mac80211.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-02-11 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 15:03 [PATCH] zd1211rw: Fix beacon filter flags thinko Michael Buesch
2008-02-11 12:53 ` Johannes Berg [this message]
2008-02-11 14:23 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202734431.11481.80.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).