linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>, Patrick McHardy <kaber@trash.net>
Cc: bruno@thinktube.com, netdev@vger.kernel.org, jgarzik@pobox.com,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: [PATCH] net/8021q/vlan_dev.c - Use print_mac
Date: Fri, 15 Feb 2008 09:42:50 -0800	[thread overview]
Message-ID: <1203097370.21308.18.camel@localhost> (raw)
In-Reply-To: <20080215.025855.202184003.davem@davemloft.net>

On Fri, 2008-02-15 at 02:58 -0800, David Miller wrote:
> From: Bruno Randolf <bruno@thinktube.com>
> Date: Fri, 15 Feb 2008 19:48:05 +0900
> > is there any chance to include a macro like this for printing mac
> addresses?
> > its advantage is that it can be used without the need to declare
> buffers for
> > print_mac(), for example:
> We specifically removed this sort of thing, please don't
> add it back.

Remove direct use of MAC_FMT

Signed-off-by: Joe Perches <joe@perches.com>

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 77f04e4..839c70e 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -366,7 +366,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 {
 	struct net_device_stats *stats = &dev->stats;
 	struct vlan_ethhdr *veth = (struct vlan_ethhdr *)(skb->data);
-
+	DECLARE_MAC_BUF(mac);
+	DECLARE_MAC_BUF(mac2);
 	/* Handle non-VLAN frames if they are sent to us, for example by DHCP.
 	 *
 	 * NOTE: THIS ASSUMES DIX ETHERNET, SPECIFICALLY NOT SUPPORTING
@@ -404,11 +405,8 @@ static int vlan_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
 	pr_debug("%s: about to send skb: %p to dev: %s\n",
 		__FUNCTION__, skb, skb->dev->name);
-	pr_debug("  " MAC_FMT " " MAC_FMT " %4hx %4hx %4hx\n",
-		 veth->h_dest[0], veth->h_dest[1], veth->h_dest[2],
-		 veth->h_dest[3], veth->h_dest[4], veth->h_dest[5],
-		 veth->h_source[0], veth->h_source[1], veth->h_source[2],
-		 veth->h_source[3], veth->h_source[4], veth->h_source[5],
+	pr_debug("  %s %s %4hx %4hx %4hx\n",
+		 print_mac(mac, veth->h_dest), print_mac(mac2, veth->h_source),
 		 veth->h_vlan_proto, veth->h_vlan_TCI,
 		 veth->h_vlan_encapsulated_proto);
 



  reply	other threads:[~2008-02-15 17:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 10:48 [PATCH] add macro for printing mac addresses Bruno Randolf
2008-02-15 10:58 ` David Miller
2008-02-15 17:42   ` Joe Perches [this message]
2008-02-18  7:35     ` [PATCH] net/8021q/vlan_dev.c - Use print_mac David Miller
2008-02-18 15:19     ` Patrick McHardy
2008-02-18 18:31       ` Joe Perches
2008-02-18 21:31         ` Patrick McHardy
2008-02-18 20:55       ` David Miller
2008-02-18 21:17         ` Patrick McHardy
2008-02-19  0:43           ` David Miller
2008-02-19  0:50             ` David Miller
2008-02-19  1:03               ` Joe Perches
2008-02-19  1:30                 ` Philip Craig
2008-02-19  3:23                 ` David Miller
2008-02-19 11:48               ` Patrick McHardy
2008-02-15 17:42   ` [PATCH 2/2] Remove MAC_FMT Joe Perches
2008-02-18  7:35     ` David Miller
2008-02-15 12:54 ` [PATCH] add macro for printing mac addresses Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203097370.21308.18.camel@localhost \
    --to=joe@perches.com \
    --cc=bruno@thinktube.com \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=kaber@trash.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).