Re: [PATCH] mac80211: check endianness/types in sparse runs

[Pavel Roskin <proski@gnu.org>]

On Wed, 2008-02-20 at 20:59 +0100, Sam Ravnborg wrote:
> On Wed, Feb 20, 2008 at 11:38:29AM +0100, Johannes Berg wrote:
> > Make sure sparse checks endianness when run on mac80211.
> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---
> > Sam, is this an OK use of makefiles or is there something else I should
> > be doing?
> 
> I would prefer it to be kernel wide enabled.
> Tried a defconfig build.

I cannot agree more.  It's not like endian warnings are some nuisance
that's OK to fix later.  There are more real bugs indicated by the
endianess warnings than by any other warnings.

Besides, the endian warnings can be disabled by adding "-Wno-bitwise" to
the sparse flags.  Not that I would recommend it to anyone.

> When I enabled __CHECK_ENDIAN I got:
> 8 files with > 100 warnings
> 14 files with 10 to 99 warnings.
> 
> So nothing that should scare a kernel hacker...
> 
> warnings without: 1686
> warnings with: 2788
> 
> OK - thats a lot, but then fixing 8 files will significantly
> reduce this.

Thanks for the statistics!

-- 
Regards,
Pavel Roskin