From: Dan Williams <dcbw@redhat.com>
To: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] PS3: gelic: Link the wireless net_device structure to the corresponding device structure
Date: Fri, 22 Feb 2008 09:11:23 -0500 [thread overview]
Message-ID: <1203689483.29957.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20080222163604.CFC0.40F06B3A@sm.sony.co.jp>
On Fri, 2008-02-22 at 16:45 +0900, Masakazu Mokuno wrote:
> Link the net_device structure of the wireless part to the
> corresponding device structure.
>
> Without this, the sysfs node for this net_device would not have
> 'device' link.
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Hmm; I must have missed this in the review. But it does need to be
there, good catch.
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> drivers/net/ps3_gelic_wireless.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/net/ps3_gelic_wireless.c
> +++ b/drivers/net/ps3_gelic_wireless.c
> @@ -2690,6 +2690,7 @@ int gelic_wl_driver_probe(struct gelic_c
> return -ENOMEM;
>
> /* setup net_device structure */
> + SET_NETDEV_DEV(netdev, &card->dev->core);
> gelic_wl_setup_netdev_ops(netdev);
>
> /* setup some of net_device and register it */
>
prev parent reply other threads:[~2008-02-22 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 7:45 [PATCH] PS3: gelic: Link the wireless net_device structure to the corresponding device structure Masakazu Mokuno
2008-02-22 14:11 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203689483.29957.0.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mokuno@sm.sony.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox