Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Luis Carlos Cobo <luisca@cozybit.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 06/13 v2] o11s: support for mesh interfaces in mac80211 data path
Date: Fri, 22 Feb 2008 17:11:32 +0100	[thread overview]
Message-ID: <1203696692.7082.58.camel@johannes.berg> (raw)
In-Reply-To: <47be773a.29578c0a.41e9.ffffa95d@mx.google.com> (sfid-20080222_071823_283753_CB1EE72E)

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]


> +#ifdef CONFIG_MAC80211_MESH
> +#include "mesh.h"
> +#endif

same here.

> @@ -1474,8 +1512,8 @@ int ieee80211_subif_start_xmit(struct sk_buff *skb,
>          * EAPOL frames from the local station.
>          */
>         if (unlikely(!is_multicast_ether_addr(hdr.addr1) &&
> -                    !(sta_flags & WLAN_STA_AUTHORIZED) &&
> -                    !(ethertype == ETH_P_PAE &&
> +                     !(sta_flags & WLAN_STA_AUTHORIZED) &&
> +                     !(ethertype == ETH_P_PAE &&
>                        compare_ether_addr(dev->dev_addr,
>                                           skb->data + ETH_ALEN) == 0))) {
>  #ifdef CONFIG_MAC80211_VERBOSE_DEBUG 

?

> +#ifdef CONFIG_MAC80211_MESH
> +static struct sk_buff *ieee80211_mesh_beacon_get(struct net_device *dev)
> +{
> +	struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
> +	struct sk_buff *skb = dev_alloc_skb(local->hw.extra_tx_headroom + 400);

What's 400? No way to know how large it'll get?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2008-02-22 16:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22  4:11 [PATCH 06/13 v2] o11s: support for mesh interfaces in mac80211 data path Luis Carlos Cobo
2008-02-22 16:11 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203696692.7082.58.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luisca@cozybit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox