Re: mac80211 locking: tasklet vs. non-tasklet

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]


> >  > Actually alike athk also iwlwifi driver calls tx_status from a tasklet
> >  > therfore the irqsafe can be removed. I've tested that it worked so far
> >
> >  Ok, fine too. Just the mixing is actually bad because of locking.
> 
> There'll be a patch for it.

Great, thanks. I'll be reposting my sta info rework today and that will
then add documentation about that too.

> >  > In general I'm missing some asynchronous mechanism that driver can
> >  > notify mac80211 about it's state.
> >  > Except BA states there  is  for example  netif_carrier_off/on
> >  > functionality in the driver level. It would be very useful for early
> >  > notification of disconnection.  A disconnection can happen due to
> >  > device resume or internal recoverable error. In this cases I would
> >  > expect mac to try associate again upon such trigger.
> >
> >  I guess that's just missing. You can stop the queues but you can't tell
> >  mac80211 that you reset the hw.
> 
> If there is no objection we will introduce some notification
> mechanism...suggestions are welcome as well.

I have no objection, though I'm unsure what precisely you want. What,
for example, if you're running hostapd and your hardware resets? Can you
keep station tables etc.?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]