From: Luis Carlos Cobo <luisca@cozybit.com>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Mattias Nissler <mattias.nissler@gmx.de>
Subject: Re: [PATCH 08/13 v2] o11s: other changes in mac80211 for mesh interface support
Date: Mon, 25 Feb 2008 13:15:13 -0800 [thread overview]
Message-ID: <1203974113.6929.93.camel@localhost> (raw)
In-Reply-To: <20080223074133.32a4609c@morte>
On Sat, 2008-02-23 at 07:41 +0100, Stefano Brivio wrote:
> I'd like to have this moved, maybe right before this:
>
> /* Compute the controller output. */
Ok.
>
> > pf <<= RC_PID_ARITH_SHIFT;
> > + sta->fail_avg = ((pf + (spinfo->last_pf << 3)) / 9)
> > + >> RC_PID_ARITH_SHIFT;
> > }
>
> What do you need fail_avg for? Please note that we have better estimates of
> the frame failure trends (e.g., err_avg). What these magic values are?
It's supposed to be an estimation of the probability of a frame
transmission failure. The magic numbers just express the formula
fail_avg = (8 * old_fail_avg + 1 * fail_avg) / 9
a simple smoothing, there is nothing special to the exact numbers.
If you think err_avg is a good candidate (is it also 0-100?) I'd be
happy to use that instead.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
next prev parent reply other threads:[~2008-02-25 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 4:17 [PATCH 08/13 v2] o11s: other changes in mac80211 for mesh interface support Luis Carlos Cobo
2008-02-22 16:16 ` Johannes Berg
2008-02-25 19:32 ` Luis Carlos Cobo
2008-02-25 19:32 ` Johannes Berg
2008-02-23 6:41 ` Stefano Brivio
2008-02-25 21:15 ` Luis Carlos Cobo [this message]
2008-02-26 20:36 ` Stefano Brivio
2008-02-29 20:56 ` Luis Carlos Cobo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203974113.6929.93.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mattias.nissler@gmx.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).