From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 06/10] mac80211: RCU-ify STA info structure access
Date: Mon, 25 Feb 2008 16:22:17 -0800 [thread overview]
Message-ID: <1203985337.6929.120.camel@localhost> (raw)
In-Reply-To: <20080225153007.340533000@sipsolutions.net>
On Mon, 2008-02-25 at 16:27 +0100, Johannes Berg wrote:
> @@ -303,8 +300,8 @@ static void mesh_path_node_reclaim(struc
> struct mpath_node *node = container_of(rp, struct mpath_node, rcu);
> struct ieee80211_sub_if_data *sdata =
> IEEE80211_DEV_TO_SUB_IF(node->mpath->dev);
> - if (node->mpath->next_hop)
> - sta_info_put(node->mpath->next_hop);
> +
> + rcu_assign_pointer(node->mpath->next_hop, NULL);
Is that necessary? If we are here nobody else should have access to this
path and we should just free it, right?
Also since now we can force deletion, the mesh path timer might be
running and we need a del_timer_sync() somewhere. After adding that, we
may as well always force the path deletion.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
next prev parent reply other threads:[~2008-02-26 0:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 15:27 [PATCH 00/10] mac80211 locking/sta info work Johannes Berg
2008-02-25 15:27 ` [PATCH 01/10] mac80211: clarify use of TX status/RX callbacks Johannes Berg
2008-02-25 15:27 ` [PATCH 02/10] mac80211: safely free beacon in ieee80211_if_reinit Johannes Berg
2008-02-25 15:27 ` [PATCH 03/10] mac80211: split ieee80211_txrx_data Johannes Berg
2008-02-25 15:27 ` [PATCH 04/10] mac80211: remove STA infos last_ack stuff Johannes Berg
2008-02-25 15:27 ` [PATCH 05/10] mac80211: split ieee80211_key_alloc/free Johannes Berg
2008-02-25 15:27 ` [PATCH 06/10] mac80211: RCU-ify STA info structure access Johannes Berg
2008-02-26 0:22 ` Luis Carlos Cobo [this message]
2008-02-26 8:23 ` Johannes Berg
2008-02-26 19:26 ` Luis Carlos Cobo
2008-02-27 11:23 ` Johannes Berg
2008-02-27 18:34 ` Luis Carlos Cobo
2008-02-25 15:27 ` [PATCH 07/10] mac80211: split sta_info_add Johannes Berg
2008-02-25 15:27 ` [PATCH 08/10] mac80211: clean up sta_info and document locking Johannes Berg
2008-02-25 15:27 ` [PATCH 09/10] mac80211: remove STA entries when taking down interface Johannes Berg
2008-02-25 15:27 ` [PATCH 10/10] b43: verify sta_notify mac80211 callback Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203985337.6929.120.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).