From: Johannes Berg <johannes@sipsolutions.net>
To: Florian Fainelli <florian.fainelli@telecomint.eu>
Cc: John Linville <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: p54: fix EEPROM structure endianness
Date: Sun, 02 Mar 2008 16:11:53 +0100 [thread overview]
Message-ID: <1204470713.3917.20.camel@johannes.berg> (raw)
In-Reply-To: <200803021559.28528.florian.fainelli@telecomint.eu> (sfid-20080302_150231_277924_AA60DE19)
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
> Le dimanche 2 mars 2008, Johannes Berg a écrit :
> > You mean my patch fixes it?
>
> Yes absolutely, before, I got error from the eeprom parsing function that it
> could not read all required eeprom fields, leading to a non-working wireless
> interface, causing oopses sometimes.
>
> With your patch, MAC address, calibration values are read correctly and I can
> use the USB dongle successfully. Of course the dongle does not oops anymore
> on big-endian hosts.
>
> Tested-by: Florian Fainelli <florian.fainelli@telecomint.eu>
Great, thanks for testing, confirms my suspicions about the eeprom
reading code. Can you do me a favour and also test my patch titled
"[PATCH] p54: fix eeprom parser length sanity checks"?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2008-03-02 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 12:56 p54: fix EEPROM structure endianness Johannes Berg
2008-03-02 12:24 ` Florian Fainelli
2008-03-02 13:40 ` Johannes Berg
2008-03-02 14:59 ` Florian Fainelli
2008-03-02 15:11 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204470713.3917.20.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=florian.fainelli@telecomint.eu \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox