Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Sebastian Siewior <bigeasy@tglx.de>
Cc: Holger Schurig <hs4233@mail.mn-solutions.de>,
	linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] [NET] libertas: compare the current command with response
Date: Tue, 04 Mar 2008 12:23:10 -0500	[thread overview]
Message-ID: <1204651390.30024.19.camel@localhost.localdomain> (raw)
In-Reply-To: <20080304172227.GA14225@www.tglx.de>

On Tue, 2008-03-04 at 18:22 +0100, Sebastian Siewior wrote:
> instead of with itself.

Woodhouse already patched this, and Holger submitted woodhouse's patch.
So I think this is solved.

Dan

> Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>
> ---
> Holger can please ACK/NACK this? According to my debug patch, it does
> the right thing.
> 
>  drivers/net/wireless/libertas/cmdresp.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
> index 159216a..013245b 100644
> --- a/drivers/net/wireless/libertas/cmdresp.c
> +++ b/drivers/net/wireless/libertas/cmdresp.c
> @@ -562,9 +562,7 @@ int lbs_process_rx_command(struct lbs_private *priv)
>  	}
>  
>  	resp = (void *)priv->upld_buf;
> -
> -	curcmd = le16_to_cpu(resp->command);
> -
> +	curcmd = le16_to_cpu(priv->cur_cmd->cmdbuf->command);
>  	respcmd = le16_to_cpu(resp->command);
>  	result = le16_to_cpu(resp->result);
>  


  reply	other threads:[~2008-03-04 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 17:22 [PATCH] [NET] libertas: compare the current command with response Sebastian Siewior
2008-03-04 17:23 ` Dan Williams [this message]
2008-03-04 18:20   ` Sebastian Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204651390.30024.19.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=bigeasy@tglx.de \
    --cc=hs4233@mail.mn-solutions.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox