[PATCH] [NET] libertas: compare the current command with response

[PATCH] [NET] libertas: compare the current command with response

[Sebastian Siewior]

instead of with itself.

Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>
---
Holger can please ACK/NACK this? According to my debug patch, it does
the right thing.

 drivers/net/wireless/libertas/cmdresp.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 159216a..013245b 100644
--- a/drivers/net/wireless/libertas/cmdresp.c
+++ b/drivers/net/wireless/libertas/cmdresp.c
@@ -562,9 +562,7 @@ int lbs_process_rx_command(struct lbs_private *priv)
 	}
 
 	resp = (void *)priv->upld_buf;
-
-	curcmd = le16_to_cpu(resp->command);
-
+	curcmd = le16_to_cpu(priv->cur_cmd->cmdbuf->command);
 	respcmd = le16_to_cpu(resp->command);
 	result = le16_to_cpu(resp->result);
 
-- 
1.5.3.5

Re: [PATCH] [NET] libertas: compare the current command with response

[Dan Williams]

On Tue, 2008-03-04 at 18:22 +0100, Sebastian Siewior wrote:
> instead of with itself.

Woodhouse already patched this, and Holger submitted woodhouse's patch.
So I think this is solved.

Dan

> Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>
> ---
> Holger can please ACK/NACK this? According to my debug patch, it does
> the right thing.
> 
>  drivers/net/wireless/libertas/cmdresp.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
> index 159216a..013245b 100644
> --- a/drivers/net/wireless/libertas/cmdresp.c
> +++ b/drivers/net/wireless/libertas/cmdresp.c
> @@ -562,9 +562,7 @@ int lbs_process_rx_command(struct lbs_private *priv)
>  	}
>  
>  	resp = (void *)priv->upld_buf;
> -
> -	curcmd = le16_to_cpu(resp->command);
> -
> +	curcmd = le16_to_cpu(priv->cur_cmd->cmdbuf->command);
>  	respcmd = le16_to_cpu(resp->command);
>  	result = le16_to_cpu(resp->result);
>  

Re: [PATCH] [NET] libertas: compare the current command with response

[Sebastian Siewior]

* Dan Williams | 2008-03-04 12:23:10 [-0500]:

>On Tue, 2008-03-04 at 18:22 +0100, Sebastian Siewior wrote:
>> instead of with itself.
Argh, I mixed up the libertas ml with wireless. Sorry for that.

>Woodhouse already patched this, and Holger submitted woodhouse's patch.
>So I think this is solved.
Holger posted five patches yesterday on the libertas ml, one of them was

|libertas: fix sanity check on sequence number in command
Are you refering to this one? 
This patch fixes the "sequence number compare" but than we still have the
"command compare" which is also comparing with itself.
In case you are talking about another one, than I have overlooked it.

>Dan
Sebastian