From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH 4/5] mac80211: remove Hi16, Lo16 helpers
Date: Sat, 08 Mar 2008 01:23:08 -0800 [thread overview]
Message-ID: <1204968188.23455.40.camel@brick> (raw)
They were only used in one place, just open-code it there.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
net/mac80211/tkip.c | 19 ++-----------------
1 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/net/mac80211/tkip.c b/net/mac80211/tkip.c
index 9a36e83..264e392 100644
--- a/net/mac80211/tkip.c
+++ b/net/mac80211/tkip.c
@@ -65,31 +65,16 @@ static inline u8 Hi8(u16 v)
return v >> 8;
}
-
static inline u8 Lo8(u16 v)
{
return v & 0xff;
}
-
-static inline u16 Hi16(u32 v)
-{
- return v >> 16;
-}
-
-
-static inline u16 Lo16(u32 v)
-{
- return v & 0xffff;
-}
-
static u16 tkip_S(u16 val)
{
return tkip_sbox[val & 0xff] ^ swab16(tkip_sbox[val >> 8]);
}
-
-
/* P1K := Phase1(TA, TK, TSC)
* TA = transmitter address (48 bits)
* TK = dot11DefaultKeyValue or dot11KeyMappingValue (128 bits)
@@ -102,8 +87,8 @@ static void tkip_mixing_phase1(const u8 *ta, const u8 *tk, u32 tsc_IV32,
int i, j;
__le16 *leptr = (__le16 *)ta;
- p1k[0] = Lo16(tsc_IV32);
- p1k[1] = Hi16(tsc_IV32);
+ p1k[0] = tsc_IV32 & 0xffff;
+ p1k[1] = tsc_IV32 >> 16;
p1k[2] = le16_to_cpup(leptr++);
p1k[3] = le16_to_cpup(leptr++);
p1k[4] = le16_to_cpup(leptr++);
--
1.5.4.GIT
next reply other threads:[~2008-03-08 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 9:23 Harvey Harrison [this message]
2008-03-12 14:54 ` [PATCH 4/5] mac80211: remove Hi16, Lo16 helpers Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204968188.23455.40.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).