From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] tkip: remove unused function, other cleanups
Date: Sun, 09 Mar 2008 17:03:46 -0700 [thread overview]
Message-ID: <1205107431.6474.1.camel@brick> (raw)
In-Reply-To: <1204959156.6387.34.camel@johannes.berg>
On Sat, 2008-03-08 at 07:52 +0100, Johannes Berg wrote:
> > -static inline u16 tkip_S(u16 val)
> > +static u16 tkip_S(u16 val)
> > {
> > - u16 a = tkip_sbox[Hi8(val)];
> > -
> > - return tkip_sbox[Lo8(val)] ^ Hi8(a) ^ (Lo8(a) << 8);
> > + return tkip_sbox[val & 0xff] ^ __swab16(tkip_sbox[val >> 8]);
>
> What's wrong with using the non-underscored versions? This is pure
> kernel code...
That was a thinko on my part, I resent this in a 5-patch series shortly
thereafter without the underscores (the alignment problems you noted in
2/2 still remain).
Thanks for the comments.
Harvey
prev parent reply other threads:[~2008-03-10 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 3:17 [PATCH 1/2] tkip: remove unused function, other cleanups Harvey Harrison
2008-03-08 6:52 ` Johannes Berg
2008-03-10 0:03 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205107431.6474.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).