From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/5] mac80211: replace Mk16 helper with le16_to_cpup
Date: Tue, 11 Mar 2008 09:21:33 -0700 [thread overview]
Message-ID: <1205252493.22317.3.camel@brick> (raw)
In-Reply-To: <1205252069.6387.52.camel@johannes.berg>
On Tue, 2008-03-11 at 17:14 +0100, Johannes Berg wrote:
> On Sat, 2008-03-08 at 01:23 -0800, Harvey Harrison wrote:
> > Opencoded byte-swapping could just use the kernel helper.
>
> > + p1k[2] = le16_to_cpup(leptr++);
>
> I'm ok with this if architectures guarantee that these operations work
> on unaligned values, but I don't think that is the case.
>
I'm looking into this, but I'm pretty sure this isn't right as-is.
I wasn't thinking about alignment at the time, just ignore this.
Harvey
prev parent reply other threads:[~2008-03-11 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 9:23 [PATCH 3/5] mac80211: replace Mk16 helper with le16_to_cpup Harvey Harrison
2008-03-11 16:14 ` Johannes Berg
2008-03-11 16:21 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205252493.22317.3.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).