From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: remove some unused commands
Date: Wed, 12 Mar 2008 21:36:51 -0400 [thread overview]
Message-ID: <1205372212.23943.6.camel@localhost.localdomain> (raw)
In-Reply-To: <200803121706.09735.hs4233@mail.mn-solutions.de>
On Wed, 2008-03-12 at 17:06 +0100, Holger Schurig wrote:
> Neither CMD_802_11_PAIRWISE_TSC nor CMD_802_11_GROUP_TSC is used or
> documented. It might have something to do with TKIP sequence counters,
> but that's just an educated guess. Remove all occurences of them.
>
> CMD_CODE_DNLD is also neither used nor documented.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
>
> Index: wireless-testing/drivers/net/wireless/libertas/cmd.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmd.c 2008-03-12 15:09:19.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/libertas/cmd.c 2008-03-12 15:41:49.000000000 +0100
> @@ -1379,8 +1379,6 @@ int lbs_prepare_and_send_command(struct
> case CMD_802_11_AD_HOC_START:
> ret = lbs_cmd_80211_ad_hoc_start(priv, cmdptr, pdata_buf);
> break;
> - case CMD_CODE_DNLD:
> - break;
>
> case CMD_802_11_RESET:
> ret = lbs_cmd_802_11_reset(priv, cmdptr, cmd_action);
> @@ -1440,11 +1438,6 @@ int lbs_prepare_and_send_command(struct
> ret = lbs_cmd_80211_ad_hoc_stop(priv, cmdptr);
> break;
>
> - case CMD_802_11_PAIRWISE_TSC:
> - break;
> - case CMD_802_11_GROUP_TSC:
> - break;
> -
> case CMD_802_11_MAC_ADDRESS:
> ret = lbs_cmd_802_11_mac_address(priv, cmdptr, cmd_action);
> break;
> Index: wireless-testing/drivers/net/wireless/libertas/host.h
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/host.h 2008-03-12 15:09:19.000000000 +0100
> +++ wireless-testing/drivers/net/wireless/libertas/host.h 2008-03-12 15:41:41.000000000 +0100
> @@ -33,7 +33,6 @@
> #define CMD_RET_802_11_ASSOCIATE 0x8012
>
> /* Command codes */
> -#define CMD_CODE_DNLD 0x0002
> #define CMD_GET_HW_SPEC 0x0003
> #define CMD_EEPROM_UPDATE 0x0004
> #define CMD_802_11_RESET 0x0005
> @@ -68,8 +67,6 @@
> #define CMD_802_11_AD_HOC_JOIN 0x002c
> #define CMD_802_11_QUERY_TKIP_REPLY_CNTRS 0x002e
> #define CMD_802_11_ENABLE_RSN 0x002f
> -#define CMD_802_11_PAIRWISE_TSC 0x0036
> -#define CMD_802_11_GROUP_TSC 0x0037
> #define CMD_802_11_SET_AFC 0x003c
> #define CMD_802_11_GET_AFC 0x003d
> #define CMD_802_11_AD_HOC_STOP 0x0040
prev parent reply other threads:[~2008-03-13 1:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 16:06 [PATCH] libertas: remove some unused commands Holger Schurig
2008-03-13 1:36 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205372212.23943.6.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox