From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: store rssi as an int
Date: Wed, 19 Mar 2008 11:39:43 -0400 [thread overview]
Message-ID: <1205941183.4169.26.camel@localhost.localdomain> (raw)
In-Reply-To: <200803191620.18554.hs4233@mail.mn-solutions.de>
On Wed, 2008-03-19 at 16:20 +0100, Holger Schurig wrote:
> > RSSI as defined in 802.11 as a positive 8-bit value; the
> > libertas firmware also reports the RSSI in scan results as a
> > u8. So I'd suggest a u8 instead of an int; an int isn't the
> > right thing to do here.
>
> "struct bss_descriptor" has nothing to do with hardware,
> otherwise you would see __le32 there. Using an "u8" saves us
> nothing, except we move all u8's at the end of the struct. But
> this would give us unaligned u8's and some processors have
> problems with that.
I still don't want an int used for a value that should never be
unsigned... I don't particularly care what size it is as long as its
unsigned. Otherwise, we should be calling it RSSI at all. Either it's
unsigned+RSSI or signed+dBm, but in the signed+dBm case we'd have to
actually _convert_ it to dBm too.
Dan
next prev parent reply other threads:[~2008-03-19 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 14:15 [PATCH] libertas: store rssi as an int Holger Schurig
2008-03-19 14:51 ` Dan Williams
2008-03-19 15:20 ` Holger Schurig
2008-03-19 15:39 ` Dan Williams [this message]
2008-03-19 16:07 ` Holger Schurig
2008-03-19 16:08 ` [PATCH, take 2] libertas: store rssi as an u32 Holger Schurig
2008-03-19 22:17 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205941183.4169.26.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox