From: Johannes Berg <johannes@sipsolutions.net>
To: Will Newton <will.newton@gmail.com>
Cc: Daniel Drake <dsd@gentoo.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH/RFC] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig symbol
Date: Thu, 20 Mar 2008 15:58:17 +0100 [thread overview]
Message-ID: <1206025097.16475.139.camel@johannes.berg> (raw)
In-Reply-To: <87a5b0800803200739v6d222afck850f221eae1edd70@mail.gmail.com> (sfid-20080320_143913_214765_488C899F)
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Thu, 2008-03-20 at 14:39 +0000, Will Newton wrote:
> On Thu, Mar 20, 2008 at 2:34 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>
> > +For some ethernet hardware that cannot DMA to unaligned addresses like
> > +4*n+2 or non-ethernet hardware, this can be a problem, and it is then
> > +required to copy the incoming frame into an aligned buffer. Because this is
> > +unnecessary on architectures that can do unaligned accesses, the code can be
> > +made depend on CONFIG_ARCH_CAN_UNALIGNED_ACCESS like so:
> > +
> > +#ifdef CONFIG_ARCH_CAN_UNALIGNED_ACCESS
> > + skb = copy skb
> > +#else
> > + skb = original skb
> > +#endif
>
> Is this logic reversed?
Euh, indeed, thanks. Will repost after having more comments.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-03-20 14:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:34 [PATCH/RFC] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig symbol Johannes Berg
2008-03-20 14:39 ` Will Newton
2008-03-20 14:58 ` Johannes Berg [this message]
2008-03-20 18:13 ` Sam Ravnborg
2008-03-20 18:35 ` Johannes Berg
2008-03-20 18:39 ` [PATCH/RFC v2] " Johannes Berg
2008-03-20 18:45 ` [PATCH/RFC v3] " Johannes Berg
2008-03-20 19:09 ` Harvey Harrison
2008-03-20 19:12 ` Johannes Berg
2008-03-20 19:41 ` Sam Ravnborg
2008-03-20 19:50 ` [PATCH/RFC v4] introduce HAVE_UNALIGNED_ACCESS_SUPPORT " Johannes Berg
2008-03-21 8:45 ` Ingo Molnar
2008-03-20 21:13 ` [PATCH/RFC v2] introduce ARCH_CAN_UNALIGNED_ACCESS " David Miller
2008-03-20 21:21 ` Johannes Berg
2008-03-20 21:27 ` David Miller
2008-03-20 22:03 ` John W. Linville
2008-03-20 22:10 ` David Miller
2008-03-25 14:11 ` [PATCH/RFC v5] introduce HAVE_EFFICIENT_UNALIGNED_ACCESS " Johannes Berg
2008-04-02 10:24 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206025097.16475.139.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).