From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, akpm@linux-foundation.org,
linville@tuxdriver.com
Subject: Re: [PATCH] mac80211: fix deadlocks in debugfs_netdev.c
Date: Tue, 01 Apr 2008 11:53:12 -0700 [thread overview]
Message-ID: <1207075992.7552.3.camel@localhost> (raw)
In-Reply-To: <1207051350.5143.56.camel@johannes.berg>
On Tue, 2008-04-01 at 14:02 +0200, Johannes Berg wrote:
> On Mon, 2008-03-31 at 15:10 -0700, Luis Carlos Cobo wrote:
> > The bug shows up with CONFIG_PREEMPT enabled. Pointed out by Andrew Morton.
>
> > @@ -51,13 +53,13 @@ static ssize_t ieee80211_if_write(
> >
> > memset(buf, 0x00, sizeof(buf));
> > buf_size = min(count, (sizeof(buf)-1));
> > - read_lock(&dev_base_lock);
> > if (copy_from_user(buf, userbuf, buf_size))
>
> Do we actually still need all this ieee80211_if_write code? It seems
> that nl80211 can fully replace it now.
Yes we do. We cannot tune mesh parameters (Mesh TTL, auto open peer
links, retries, timeouts, and other dozen parameters) through nl80211.
As the values for those parameters are not yet defined, these knobs are
very useful for performance analysis.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
prev parent reply other threads:[~2008-04-01 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 22:10 [PATCH] mac80211: fix deadlocks in debugfs_netdev.c Luis Carlos Cobo
2008-04-01 12:02 ` Johannes Berg
2008-04-01 18:53 ` Luis Carlos Cobo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207075992.7552.3.camel@localhost \
--to=luisca@cozybit.com \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).