From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: fix mode initialization problem
Date: Wed, 02 Apr 2008 23:33:02 -0400 [thread overview]
Message-ID: <1207193582.9435.6.camel@localhost.localdomain> (raw)
In-Reply-To: <200804021634.51406.hs4233@mail.mn-solutions.de>
On Wed, 2008-04-02 at 16:34 +0200, Holger Schurig wrote:
> After moving lbs_find_best_network_ssid() from scan.c to assoc.c gcc was
> able to deduce that new_mode might stay uninitialized.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-testing/drivers/net/wireless/libertas/assoc.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/assoc.c 2008-04-02 14:29:48.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/assoc.c 2008-04-02 14:31:10.000000000 +0200
> @@ -1021,7 +1021,7 @@ void lbs_association_worker(struct work_
> }
>
> if (find_any_ssid) {
> - u8 new_mode;
> + u8 new_mode = assoc_req->mode;
>
> ret = lbs_find_best_network_ssid(priv, assoc_req->ssid,
> &assoc_req->ssid_len, assoc_req->mode, &new_mode);
prev parent reply other threads:[~2008-04-03 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 14:34 [PATCH] libertas: fix mode initialization problem Holger Schurig
2008-04-03 3:33 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207193582.9435.6.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox