From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: move lbs_update_channel out of assoc.c
Date: Wed, 02 Apr 2008 23:33:28 -0400 [thread overview]
Message-ID: <1207193608.9435.8.camel@localhost.localdomain> (raw)
In-Reply-To: <200804021652.19572.hs4233@mail.mn-solutions.de>
On Wed, 2008-04-02 at 16:52 +0200, Holger Schurig wrote:
> ... as it has nothing to do with pure association
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-testing/drivers/net/wireless/libertas/assoc.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/assoc.c 2008-04-02 14:49:22.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/assoc.c 2008-04-02 14:50:25.000000000 +0200
> @@ -583,23 +583,6 @@ done:
> return ret;
> }
>
> -
> -int lbs_update_channel(struct lbs_private *priv)
> -{
> - int ret;
> -
> - /* the channel in f/w could be out of sync; get the current channel */
> - lbs_deb_enter(LBS_DEB_ASSOC);
> -
> - ret = lbs_get_channel(priv);
> - if (ret > 0) {
> - priv->curbssparams.channel = ret;
> - ret = 0;
> - }
> - lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
> - return ret;
> -}
> -
> static int assoc_helper_channel(struct lbs_private *priv,
> struct assoc_request * assoc_req)
> {
> Index: wireless-testing/drivers/net/wireless/libertas/cmd.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmd.c 2008-04-02 14:50:03.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/cmd.c 2008-04-02 14:50:22.000000000 +0200
> @@ -826,6 +826,22 @@ out:
> return ret;
> }
>
> +int lbs_update_channel(struct lbs_private *priv)
> +{
> + int ret;
> +
> + /* the channel in f/w could be out of sync; get the current channel */
> + lbs_deb_enter(LBS_DEB_ASSOC);
> +
> + ret = lbs_get_channel(priv);
> + if (ret > 0) {
> + priv->curbssparams.channel = ret;
> + ret = 0;
> + }
> + lbs_deb_leave_args(LBS_DEB_ASSOC, "ret %d", ret);
> + return ret;
> +}
> +
> /**
> * @brief Set the radio channel
> *
prev parent reply other threads:[~2008-04-03 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 14:52 [PATCH] libertas: move lbs_update_channel out of assoc.c Holger Schurig
2008-04-03 3:33 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207193608.9435.8.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).