From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: remove lbs_get_fwversion()
Date: Wed, 02 Apr 2008 23:33:41 -0400 [thread overview]
Message-ID: <1207193621.9435.10.camel@localhost.localdomain> (raw)
In-Reply-To: <200804021804.35559.hs4233@mail.mn-solutions.de>
On Wed, 2008-04-02 at 18:04 +0200, Holger Schurig wrote:
> It was used only at one place anyway.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-testing/drivers/net/wireless/libertas/ethtool.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/ethtool.c 2008-04-02 15:56:13.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/ethtool.c 2008-04-02 16:00:35.000000000 +0200
> @@ -24,13 +24,14 @@ static void lbs_ethtool_get_drvinfo(stru
> struct ethtool_drvinfo *info)
> {
> struct lbs_private *priv = (struct lbs_private *) dev->priv;
> - char fwver[32];
> -
> - lbs_get_fwversion(priv, fwver, sizeof(fwver) - 1);
>
> + snprintf(info->fw_version, 32, "%u.%u.%u.p%u",
> + priv->fwrelease >> 24 & 0xff,
> + priv->fwrelease >> 16 & 0xff,
> + priv->fwrelease >> 8 & 0xff,
> + priv->fwrelease & 0xff);
> strcpy(info->driver, "libertas");
> strcpy(info->version, lbs_driver_version);
> - strcpy(info->fw_version, fwver);
> }
>
> /* All 8388 parts have 16KiB EEPROM size at the time of writing.
> Index: wireless-testing/drivers/net/wireless/libertas/decl.h
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/decl.h 2008-04-02 15:59:57.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/decl.h 2008-04-02 16:00:01.000000000 +0200
> @@ -37,9 +37,6 @@ void lbs_notify_command_response(struct
> int lbs_set_radio_control(struct lbs_private *priv);
> u32 lbs_fw_index_to_data_rate(u8 index);
> u8 lbs_data_rate_to_fw_index(u32 rate);
> -void lbs_get_fwversion(struct lbs_private *priv,
> - char *fwversion,
> - int maxlen);
>
> /** The proc fs interface */
> int lbs_process_command_response(struct lbs_private *priv, u8 *data, u32 len);
> Index: wireless-testing/drivers/net/wireless/libertas/wext.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/wext.c 2008-04-02 15:56:20.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/wext.c 2008-04-02 16:00:25.000000000 +0200
> @@ -2060,23 +2060,6 @@ static int lbs_set_wap(struct net_device
> return ret;
> }
>
> -void lbs_get_fwversion(struct lbs_private *priv, char *fwversion, int maxlen)
> -{
> - char fwver[32];
> -
> - mutex_lock(&priv->lock);
> -
> - sprintf(fwver, "%u.%u.%u.p%u",
> - priv->fwrelease >> 24 & 0xff,
> - priv->fwrelease >> 16 & 0xff,
> - priv->fwrelease >> 8 & 0xff,
> - priv->fwrelease & 0xff);
> -
> - mutex_unlock(&priv->lock);
> - snprintf(fwversion, maxlen, fwver);
> -}
> -
> -
> /*
> * iwconfig settable callbacks
> */
prev parent reply other threads:[~2008-04-03 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 16:04 [PATCH] libertas: remove lbs_get_fwversion() Holger Schurig
2008-04-03 3:33 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207193621.9435.10.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox