From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: un-garbage various command structs
Date: Wed, 09 Apr 2008 12:13:13 -0400 [thread overview]
Message-ID: <1207757593.31194.4.camel@localhost.localdomain> (raw)
In-Reply-To: <200804091023.31707.hs4233@mail.mn-solutions.de>
On Wed, 2008-04-09 at 10:23 +0200, Holger Schurig wrote:
> Some command structs contain reserved or unused fields, which the driver
> send uninitialized down to the card.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-testing/drivers/net/wireless/libertas/cmd.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/cmd.c 2008-04-08 18:45:29.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/cmd.c 2008-04-08 20:05:11.000000000 +0200
> @@ -296,6 +296,7 @@ int lbs_cmd_802_11_set_wep(struct lbs_pr
>
> lbs_deb_enter(LBS_DEB_CMD);
>
> + memset(&cmd, 0, sizeof(cmd));
> cmd.hdr.command = cpu_to_le16(CMD_802_11_SET_WEP);
> cmd.hdr.size = cpu_to_le16(sizeof(cmd));
>
> @@ -359,7 +360,9 @@ int lbs_cmd_802_11_enable_rsn(struct lbs
> cmd.hdr.size = cpu_to_le16(sizeof(cmd));
> cmd.action = cpu_to_le16(cmd_action);
>
> - if (cmd_action == CMD_ACT_SET) {
> + if (cmd_action == CMD_ACT_GET)
> + cmd.enable = 0;
> + else {
> if (*enable)
> cmd.enable = cpu_to_le16(CMD_ENABLE_RSN);
> else
> @@ -811,6 +814,7 @@ int lbs_get_channel(struct lbs_private *
>
> lbs_deb_enter(LBS_DEB_CMD);
>
> + memset(&cmd, 0, sizeof(cmd));
> cmd.hdr.size = cpu_to_le16(sizeof(cmd));
> cmd.action = cpu_to_le16(CMD_OPT_802_11_RF_CHANNEL_GET);
>
> @@ -858,6 +862,7 @@ int lbs_set_channel(struct lbs_private *
>
> lbs_deb_enter(LBS_DEB_CMD);
>
> + memset(&cmd, 0, sizeof(cmd));
> cmd.hdr.size = cpu_to_le16(sizeof(cmd));
> cmd.action = cpu_to_le16(CMD_OPT_802_11_RF_CHANNEL_SET);
> cmd.channel = cpu_to_le16(channel);
prev parent reply other threads:[~2008-04-09 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-09 8:23 [PATCH] libertas: un-garbage various command structs Holger Schurig
2008-04-09 16:13 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207757593.31194.4.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox