linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: Fix ethtool statistics
Date: Thu, 17 Apr 2008 14:02:43 -0400	[thread overview]
Message-ID: <1208455363.20193.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1208448814.9212.270.camel@pmac.infradead.org>

On Thu, 2008-04-17 at 17:13 +0100, David Woodhouse wrote:
> We removed CMD_MESH_ACCESS from the big case statements and provided
> lbs_mesh_access() instead.... but we missed one user. Fix it.
> 
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>

Acked-by: Dan Williams <dcbw@redhat.com>

> 
> diff --git a/drivers/net/wireless/libertas/ethtool.c b/drivers/net/wireless/libertas/ethtool.c
> index 21e6f98..9460300 100644
> --- a/drivers/net/wireless/libertas/ethtool.c
> +++ b/drivers/net/wireless/libertas/ethtool.c
> @@ -106,8 +106,8 @@ done:
>          return ret;
>  }
>  
> -static void lbs_ethtool_get_stats(struct net_device * dev,
> -				struct ethtool_stats * stats, u64 * data)
> +static void lbs_ethtool_get_stats(struct net_device *dev,
> +				  struct ethtool_stats *stats, u64 *data)
>  {
>  	struct lbs_private *priv = dev->priv;
>  	struct cmd_ds_mesh_access mesh_access;
> @@ -116,9 +116,7 @@ static void lbs_ethtool_get_stats(struct net_device * dev,
>  	lbs_deb_enter(LBS_DEB_ETHTOOL);
>  
>  	/* Get Mesh Statistics */
> -	ret = lbs_prepare_and_send_command(priv,
> -			CMD_MESH_ACCESS, CMD_ACT_MESH_GET_STATS,
> -			CMD_OPTION_WAITFORRSP, 0, &mesh_access);
> +	ret = lbs_mesh_access(priv, CMD_ACT_MESH_GET_STATS, &mesh_access);
>  
>  	if (ret)
>  		return;
> 


  reply	other threads:[~2008-04-17 18:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 16:13 [PATCH] libertas: Fix ethtool statistics David Woodhouse
2008-04-17 18:02 ` Dan Williams [this message]
2008-04-17 19:44   ` Sebastian Siewior
2008-04-18 11:09     ` David Woodhouse
2008-05-10  7:24     ` [PATCH] [NET] libertas: check for mesh support before trying to use it Sebastian Siewior
2008-05-12 16:34       ` Dan Williams
2008-05-12 20:51         ` Sebastian Siewior
2008-05-13  0:09           ` John W. Linville
2008-04-18  9:02 ` [PATCH] libertas: Fix ethtool statistics Holger Schurig
2008-04-18  9:11   ` David Woodhouse
2008-04-18  9:49     ` Holger Schurig
2008-04-18 11:15       ` David Woodhouse
2008-04-18 13:10         ` Holger Schurig
2008-04-20  8:41           ` Sebastian Siewior
2008-04-20 10:56             ` David Woodhouse
2008-04-20 19:10               ` Sebastian Siewior
2008-04-21  6:42                 ` David Woodhouse
  -- strict thread matches above, loose matches on Subject: below --
2008-05-19 15:32 David Woodhouse
2008-05-19 15:47 ` Dan Williams
2008-05-19 17:20 ` Sebastian Siewior
2008-05-20  7:54 ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1208455363.20193.3.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).