From: Harvey Harrison <harvey.harrison@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: akpm@linux-foundation.org, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, jbenc@suse.cz
Subject: Re: [patch 6/7] mac80211: michael.c use unaligned/byteorder helpers
Date: Sat, 19 Apr 2008 12:31:56 -0700 [thread overview]
Message-ID: <1208633516.7941.1.camel@brick> (raw)
In-Reply-To: <480A38FA.3090300@lwfinger.net>
On Sat, 2008-04-19 at 13:24 -0500, Larry Finger wrote:
> akpm@linux-foundation.org wrote:
> > From: Harvey Harrison <harvey.harrison@gmail.com>
> >
> > Rather than open-coding the get/put of little endian values, use
> > get/put_unaligned and the byteorder helpers.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > Cc: Jiri Benc <jbenc@suse.cz>
> > Cc: John W. Linville <linville@tuxdriver.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
>
> The set of 7 patches break my system, which is x86_64 using WPA-PSK
> TKIP. If I back out #6 and 7, then all is OK.
>
> Does this series have any prerequisites? I'm running the current
> wireless-testing git tree.
>
Thanks for the testing, I posted an updated patchset on Thursday
last week and this set has been dropped from -mm.
The new patchset depends on the new unaligned helpers in -mm,
if you want I can send you a full set if you feel like testing
them.
Harvey
next prev parent reply other threads:[~2008-04-19 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:59 [patch 6/7] mac80211: michael.c use unaligned/byteorder helpers akpm
2008-04-19 18:24 ` Larry Finger
2008-04-19 19:31 ` Harvey Harrison [this message]
2008-04-20 2:25 ` Larry Finger
2008-04-19 18:38 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208633516.7941.1.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).