From: Zhu Yi <yi.zhu@intel.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: simplify code in util.c
Date: Mon, 21 Apr 2008 13:24:00 +0800 [thread overview]
Message-ID: <1208755440.2595.7.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1208745396.7941.14.camel@brick>
On Sun, 2008-04-20 at 19:36 -0700, Harvey Harrison wrote:
> - hdrlen += (fc & IEEE80211_STYPE_QOS_DATA)
> - >> (ilog2(IEEE80211_STYPE_QOS_DATA)-1);
> + if (fc & IEEE80211_STYPE_QOS_DATA)
> + hdrlen += 2;
You need also take other QoS types (i.e QOS_NULLFUNC) into
consideration. Please take a look at WLAN_FC_IS_QOS_DATA macro.
Thanks,
-yi
next prev parent reply other threads:[~2008-04-21 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 2:36 [PATCH] mac80211: simplify code in util.c Harvey Harrison
2008-04-21 5:24 ` Zhu Yi [this message]
2008-04-21 5:50 ` Harvey Harrison
2008-04-21 8:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208755440.2595.7.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox