Re: [PATCH 4/9] rt2x00: Use rt2x00 queue numbering

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]

Hi Ivo,

On Mon, 2008-04-21 at 19:00 +0200, Ivo van Doorn wrote:
> Use the rt2x00 queue enumeration as much as possible,
> removing the usage of the mac80211 queue numbering
> wherever it is possible.
> 
> This makes it easier for mac80211 to change it queue
> identification scheme without having to deal with
> big changes in the rt2x00 code.

Cool, thanks a lot. One small note:

> +static inline enum data_queue_qid mac80211_queue_to_qid(unsigned int queue)
> +{
> +	/* Regular TX queues are mapped directly */
> +	if (queue < NUM_TX_DATA_QUEUES)
> +		return queue;
> +	else if (queue == IEEE80211_TX_QUEUE_BEACON)
> +		return QID_BEACON;
> +	else if (queue == IEEE80211_TX_QUEUE_AFTER_BEACON)
> +		return QID_ATIM;
> +	return QID_OTHER;

Are you actually using TX_QUEUE_AFTER_BEACON? That queue number is a
historical accident (imho) and not used, we actually use the
IEEE80211_TXCTL_SEND_AFTER_DTIM tx control flag.

Also, with the QoS patch, those queue numbers should finally go away and
mac80211 will not pass anything but the data queues, hence, this small
inline would probably be reduced to "return queue;" by the patch.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]