From: Zhu Yi <yi.zhu@intel.com>
To: Dan Williams <dcbw@redhat.com>
Cc: linux-wireless@vger.kernel.org,
ipw2100-devel@lists.sourceforge.net,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [Ipw2100-devel] ipw2200: queue direct scans
Date: Tue, 22 Apr 2008 09:50:43 +0800 [thread overview]
Message-ID: <1208829043.5327.13.camel@debian.sh.intel.com> (raw)
In-Reply-To: <1208800153.30994.25.camel@localhost.localdomain>
On Mon, 2008-04-21 at 13:49 -0400, Dan Williams wrote:
> When another scan is in progress, a direct scan gets dropped on the
> floor. However, that direct scan is usually the scan that's really
> needed by userspace, and gets stomped on by all the broadcast scans
> the
> ipw2200 driver issues internally. Make sure the direct scan happens
> eventually, and as a bonus ensure that the passive scan worker is
> cleaned up when appropriate.
>
> The change of request_passive_scan form a struct work to struct
> delayed_work is only to make the set_wx_scan() code a bit simpler,
> it's
> still only used with a delay of 0 to match previous behavior.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
I agree with you the idea to split the current active request_scan into
active direct scan and active broadcast scan. But can you merge your
ipw_request_direct_scan_helper into ipw_request_scan_helper so that we
don't duplicate the code?
Thanks,
-yi
next prev parent reply other threads:[~2008-04-22 2:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 17:49 ipw2200: queue direct scans Dan Williams
2008-04-22 1:50 ` Zhu Yi [this message]
2008-04-22 2:56 ` [Ipw2100-devel] " Dan Williams
2008-06-02 17:51 ` [PATCH v2] " Dan Williams
2008-06-03 2:11 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208829043.5327.13.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=dcbw@redhat.com \
--cc=ipw2100-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).