From: Dan Williams <dcbw@redhat.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: mcgrof@gmail.com, linux-wireless@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] prism54: prism54_get_encode() test below 0 on unsigned index
Date: Thu, 24 Apr 2008 13:09:33 -0400 [thread overview]
Message-ID: <1209056973.5224.0.camel@localhost.localdomain> (raw)
In-Reply-To: <480F9481.2040303@tiscali.nl>
On Wed, 2008-04-23 at 21:56 +0200, Roel Kluin wrote:
> previously in this function:
>
> u32 index = (dwrq->flags & IW_ENCODE_INDEX) - 1;
Probably should just change that to an 'int' instead of a u32.
Dan
> index is unsigned, so if -1, the original test (below) didn't work.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c
> index e5b3c28..5b375b2 100644
> --- a/drivers/net/wireless/prism54/isl_ioctl.c
> +++ b/drivers/net/wireless/prism54/isl_ioctl.c
> @@ -1186,7 +1186,7 @@ prism54_get_encode(struct net_device *ndev, struct iw_request_info *info,
> rvalue |= mgt_get_request(priv, DOT11_OID_DEFKEYID, 0, NULL, &r);
> devindex = r.u;
> /* Now get the key, return it */
> - if ((index < 0) || (index > 3))
> + if (index == -1 || index > 3)
> /* no index provided, use the current one */
> index = devindex;
> rvalue |= mgt_get_request(priv, DOT11_OID_DEFKEYX, index, NULL, &r);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-24 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 19:56 [PATCH] prism54: prism54_get_encode() test below 0 on unsigned index Roel Kluin
2008-04-24 17:09 ` Dan Williams [this message]
2008-04-25 0:45 ` [PATCH v2] " Roel Kluin
2008-04-26 4:39 ` Luis R. Rodriguez
2008-04-28 4:10 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209056973.5224.0.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).