From: Johannes Berg <johannes@sipsolutions.net>
To: Vladimir Koutny <vlado@work.ksp.sk>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] WARNING: at net/mac80211/ieee80211_rate.h:159 rate_lowest_index()
Date: Wed, 30 Apr 2008 16:20:15 +0200 [thread overview]
Message-ID: <1209565215.18659.26.camel@johannes.berg> (raw)
In-Reply-To: <48174652.6080909@work.ksp.sk> (sfid-20080429_180141_582175_8C7B6399)
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
> because sdata->u.sta.supp_rates_bits is set only when we actually
> join an ibss, which is not the case in this scenario; so we assign
> zero here. Then, the code in rate_control_pid_rate_init() calls
> rate_lowest_index() for some reason, and since no supported rate is
> found, this warning is issued.
>
>
> The question is how sta->supp_rates should be initialized:
>
> - we could initialize it to our sta's rates, but then we could
> probably transmit to a station at unsupported rate
>
> - add new ibss station only on received beacon, not on a data frame;
> currently, beacons are ignored for this purpose (they just update
> the bss list later on)
>
> - something else (like 1Mbps only)?
>
> As soon as we do sta_join_ibss(), this warning won't happen again.
>
>
> Note that once we have sta entry (in our ibss), we will update its
> supported rates based on beacons it sends (in rx_bss_info()).
>
> Any thoughts?
I don't know. I don't use IBSS nor am I intimately familiar with the
specs for it.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2008-04-30 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 16:01 [RFC] WARNING: at net/mac80211/ieee80211_rate.h:159 rate_lowest_index() Vladimir Koutny
2008-04-29 18:42 ` bruno randolf
2008-04-30 15:03 ` Vladimir Koutny
2008-04-30 15:05 ` Johannes Berg
2008-04-30 15:46 ` Vladimir Koutny
2008-04-30 14:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209565215.18659.26.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vlado@work.ksp.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox