From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: fix use-before-check violation
Date: Wed, 30 Apr 2008 16:21:46 -0400 [thread overview]
Message-ID: <1209586906.16194.8.camel@localhost.localdomain> (raw)
In-Reply-To: <200804291007.56406.hs4233@mail.mn-solutions.de>
On Tue, 2008-04-29 at 10:07 +0200, Holger Schurig wrote:
> [PATCH] fix use-before-check violation
>
> According to Coverity (kudo's to Adrian Bunk), we had one use-before-check
> bug in libe libertas driver. This patch fixes this issue.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-testing/drivers/net/wireless/libertas/scan.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/scan.c 2008-04-29 09:07:19.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/scan.c 2008-04-29 09:07:39.000000000 +0200
> @@ -298,7 +298,8 @@ static int lbs_do_scan(struct lbs_privat
> uint8_t *tlv; /* pointer into our current, growing TLV storage area */
>
> lbs_deb_enter_args(LBS_DEB_SCAN, "bsstype %d, chanlist[].chan %d, chan_count %d",
> - bsstype, chan_list[0].channumber, chan_count);
> + bsstype, chan_list ? chan_list[0].channumber : -1,
> + chan_count);
>
> /* create the fixed part for scan command */
> scan_cmd = kzalloc(MAX_SCAN_CFG_ALLOC, GFP_KERNEL);
prev parent reply other threads:[~2008-04-30 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 8:07 [PATCH] libertas: fix use-before-check violation Holger Schurig
2008-04-30 20:21 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209586906.16194.8.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).