From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: debug output tweaks for lbs_thread
Date: Wed, 30 Apr 2008 16:22:05 -0400 [thread overview]
Message-ID: <1209586925.16194.10.camel@localhost.localdomain> (raw)
In-Reply-To: <200804301050.07808.hs4233@mail.mn-solutions.de>
On Wed, 2008-04-30 at 10:50 +0200, Holger Schurig wrote:
> * make debug output match the variable name
> * always report that lbs_remove_rtap() has has been exited
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-testing/drivers/net/wireless/libertas/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/main.c 2008-04-30 09:21:45.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/main.c 2008-04-30 09:24:05.000000000 +0200
> @@ -703,7 +703,7 @@ static int lbs_thread(void *data)
>
> if (shouldsleep) {
> lbs_deb_thread("sleeping, connect_status %d, "
> - "ps_mode %d, ps_state %d\n",
> + "psmode %d, psstate %d\n",
> priv->connect_status,
> priv->psmode, priv->psstate);
> spin_unlock_irq(&priv->driver_lock);
> @@ -1532,10 +1532,11 @@ static void lbs_remove_rtap(struct lbs_p
> {
> lbs_deb_enter(LBS_DEB_MAIN);
> if (priv->rtap_net_dev == NULL)
> - return;
> + goto out;
> unregister_netdev(priv->rtap_net_dev);
> free_netdev(priv->rtap_net_dev);
> priv->rtap_net_dev = NULL;
> +out:
> lbs_deb_leave(LBS_DEB_MAIN);
> }
>
prev parent reply other threads:[~2008-04-30 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 8:50 [PATCH] libertas: debug output tweaks for lbs_thread Holger Schurig
2008-04-30 20:22 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1209586925.16194.10.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox