[PATCH] libertas: rename thread names

[PATCH] libertas: rename thread names

[Holger Schurig]

* Most thread names start with "k", so we can do the same
* the module is named "libertas", so a "klibertas_XXX" thread
  name more self-describing
* one thread is a "struct task_struct", the other a workqueue,
  let this be reflected in the name

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

Index: wireless-testing/drivers/net/wireless/libertas/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/libertas/main.c	2008-04-30 08:48:04.000000000 +0200
+++ wireless-testing/drivers/net/wireless/libertas/main.c	2008-04-30 09:01:22.000000000 +0200
@@ -1122,15 +1122,14 @@ struct lbs_private *lbs_add_card(void *c
 
 	priv->rtap_net_dev = NULL;
 
-	lbs_deb_thread("Starting main thread...\n");
 	init_waitqueue_head(&priv->waitq);
-	priv->main_thread = kthread_run(lbs_thread, dev, "lbs_main");
+	priv->main_thread = kthread_run(lbs_thread, dev, "klibertasd");
 	if (IS_ERR(priv->main_thread)) {
 		lbs_deb_thread("Error creating main thread.\n");
 		goto err_init_adapter;
 	}
 
-	priv->work_thread = create_singlethread_workqueue("lbs_worker");
+	priv->work_thread = create_singlethread_workqueue("klibertasq");
 	INIT_DELAYED_WORK(&priv->assoc_work, lbs_association_worker);
 	INIT_DELAYED_WORK(&priv->scan_work, lbs_scan_worker);
 	INIT_WORK(&priv->sync_channel, lbs_sync_channel_worker);

Re: [PATCH] libertas: rename thread names

[Dan Williams]

On Wed, 2008-04-30 at 10:51 +0200, Holger Schurig wrote:
> * Most thread names start with "k", so we can do the same
> * the module is named "libertas", so a "klibertas_XXX" thread
>   name more self-describing
> * one thread is a "struct task_struct", the other a workqueue,
>   let this be reflected in the name

It appears that of the other drivers that do something like this:

airo: uses device name
ipw2200: uses driver name (ipw2200)
iwlwifi: uses driver name (iwl3945)

I guess I'd rather go with those, seems odd to put a 'k' in front when
it's a driver thread and not too many other drivers put a 'k' in front.

Dan

> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
> 
> Index: wireless-testing/drivers/net/wireless/libertas/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/libertas/main.c	2008-04-30 08:48:04.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/libertas/main.c	2008-04-30 09:01:22.000000000 +0200
> @@ -1122,15 +1122,14 @@ struct lbs_private *lbs_add_card(void *c
>  
>  	priv->rtap_net_dev = NULL;
>  
> -	lbs_deb_thread("Starting main thread...\n");
>  	init_waitqueue_head(&priv->waitq);
> -	priv->main_thread = kthread_run(lbs_thread, dev, "lbs_main");
> +	priv->main_thread = kthread_run(lbs_thread, dev, "klibertasd");
>  	if (IS_ERR(priv->main_thread)) {
>  		lbs_deb_thread("Error creating main thread.\n");
>  		goto err_init_adapter;
>  	}
>  
> -	priv->work_thread = create_singlethread_workqueue("lbs_worker");
> +	priv->work_thread = create_singlethread_workqueue("klibertasq");
>  	INIT_DELAYED_WORK(&priv->assoc_work, lbs_association_worker);
>  	INIT_DELAYED_WORK(&priv->scan_work, lbs_scan_worker);
>  	INIT_WORK(&priv->sync_channel, lbs_sync_channel_worker);

Re: [PATCH] libertas: rename thread names

[Holger Schurig]

> I guess I'd rather go with those, seems odd to put a 'k' in front when
> it's a driver thread and not too many other drivers put a 'k' in front.

Ok, it was cosmetic anyway.