Re: mac80211 truesize bugs

Tomas Winkler
2008-05-13T21:12:10Z

On Tue, May 13, 2008 at 11:59 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Tue, 2008-05-13 at 16:39 -0400, John W. Linville wrote:
> > On Mon, May 12, 2008 at 08:17:51PM -0700, David Miller wrote:
> >
> > > Based upon them I will adjust LL_MAX_HEADER as follows:
> >
> > > @@ -93,14 +93,16 @@ struct wireless_dev;
> > > * used.
> > > */
> > >
> > > -#if !defined(CONFIG_AX25) && !defined(CONFIG_AX25_MODULE) && !defined(CONFIG_TR)
> > > -#define LL_MAX_HEADER 32
> > > +#if defined(CONFIG_WLAN_80211) || defined(CONFIG_AX25) || defined(CONFIG_AX25_MODULE)
> >
> > Is WLAN_80211 really the right symbol here? It applies to more than
> > just mac80211, and I doubt if full MAC devices need higher values.
> > It seems like MAC80211 would be the right symbol to add.
>
> Most fullmac devices also need some space, whether they do things that
> way or not is a completely different thing, the ieee80211 stack for
> example copies every packet into a new skb anyway.

It's really depends on when is the 802.3 to 802.11 header translation
made it doesn't matter whether it's fullmac or softmac. I would say
that WLAN is OK.

Tomas